-
-
Notifications
You must be signed in to change notification settings - Fork 9
Add build mode tests (ensuring isDevelopingApp and isTesting are appropriately true when they need to be (as well as assert-stripping)) #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| "c8": "^7.11.3", | ||
| "ember-cli": "github:ember-cli/ember-cli#master", | ||
| "execa": "^9.5.2", | ||
| "execa": "^9.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be PR'd separately
| addonDir = join(tmpDir, addonName); | ||
| await execa({ | ||
| cwd: tmpDir, | ||
| extendEnv: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extendEnv is noise in this PR without an accompanying env: {} to set the env to empty
|
Would be nice to get this PR In ember-basic-dropdown i have |
8a895fd to
da5827f
Compare
|
@NullVoxPopuli the fix of this branch works only partially... I have an issue found out with ember-power-select and ember-basic-dropdown. When the If you run this in ember app test (like ember-power-select docs), If you want test this issue, you can do this with following steps.
The |
|
Today i have again debugged the issue from power select / basic dropdown. I have moved macro to peerDep in ember-basic-dropdown, but this hasn't solved the issue... The only way to get inside basic dropdown Inside Maybe the best and clean way will be, that addon's which are using |
|
what happens if you remove |
tried locally with an patch, removing in ember-basic-dropdown the |
d8c6aa6 to
2128af4
Compare
what happens when you cd into |
|
|
I would expect macros to not return a result, if you're testing in a full app, fwiw -- this leads me to believe a potential peer issue - maybe injected deps are needed |
followup to: #64
Key changes:
@glimmer/envforDEBUGsupport (only for the dev/test babel.config)@embroider/macros/src/vendor/embroider-macros-test-support